And it’s been nine days since we learned 0.19.1 didn’t fix the problem. There’s a lesson to be learned here: don’t push a massive update close to the holidays because, ya know, you might break federation and go on vacation for a week+.
There is also a lesson in implementing proper tests. During these holidays I started to play a bit more with Rust and went on to look at Lemmy’s backend code. Not a single unit test in sight…
We all await your commit containing all those simple unit tests with bated breath.
I want to work an issue that is open since 2020, but I can only justify dropping all my other work for that if I have enough paying customers interested in some new feature. So, help me get 50 customers to my “all in one” hosting service and I will dedicate a week to it, which should be more than enough time for even a Rust newbie like me to submit a proper PR to that issue. Ok?
There is already an open PR for Oauth, though Im not sure whats the difference to LDAP. Regarding tests you must have looked in the wrong place, we have a couple hundred already. Docs are here.
Unless there is some thing inherent to how Rust runs tests, the test script seems be mostly integration tests exercising the API. There does not seem to be unit tests which would be the first thing you’d need to have to test like the function that seems to be the source of the bug. (Hint, if your test suite needs to have a running db, you are not unit testing.)
As for OAuth vs LDAP: both could be used as part of a Single Sign-On solution, but the actual use cases are completely different. Having LDAP authentication would allow, e.g., to let users authenticate to Lemmy using an intranet account or (in the case of Communick) customers could use the same credentials for their Mastodon or Matrix accounts.
Sounds like you are looking at the api tests then. There are also unit tests which you can run with
./scripts/test.sh. The database is a fundamental part of Lemmy, so its obviously required for many of the unit tests. It may be possible to mock the db, but that would be a lot of effort for very little benefit, and might even introduce additional bugs.
Yeah and plz send 2000€ and I’ll work on it too.
deleted by creator
To be fair, I’ve yet had a job that actually pulls off unit testing. Most either don’t bother or just go for the grunt work bare minimum to force pass tests. Most friends in my field have had pretty much the same experience. Unit tests can be just a chore with little to no real benefit. Maybe an opensource project that actually cares about its code can pull it off, but I wouldn’t bat an eye if they never get to it.
If you go through the comments, you will see that the devs talk about an issue with the logic in the for loop, which “may be stopping before it should”. Writing a couple of test cases that check whether this is true or not should be trivial.
I’d expect at the very least some type of regression tests to be implemented for every bug that makes into production, to avoid cases like this one where the developers spend weeks figuring out whether their patches even fix the bug in the first place.
I’m surprised that’s your experience. I’ve worked 4 software engineering jobs now, and every single project has had well done unit test suites.
What kind of job do you have, making websites?
Usually a React dev, have been some other stuff, but generally yeah, websites. Anything from resort chain websites to complex internal applications. Unit tests were optional at best in most jobs I’ve been at. I’ve heard of jobs where they’re pulled off, but from what I’ve seen, those are the exception and not the rule.
Edit: given the downvotes on my other comment, I should add that this is both anecdotal and unopinionated from my behalf. My opinion on unit testing is “meh”, if I’m asked to do tests, I’ll do tests, if not, I won’t. I wouldn’t go out of my way to implement them, say, on a personal project or most work projects, but if I was tasked to lead certain project and that project could clearly benefit from them (i.e. Fintech, data security, high availability operation-critical tools), I wouldn’t think twice about it. Most of what I’ve worked on, however, has not been that operation-critical. What few things were critical in my work experience, would sometimes be the only code being unit tested.
That explains why you haven’t seen many unit tests then.
I guess you haven’t really worked on complex software just yet too, like a 2GB sourscode 700 projects all in one where tests saves the day all the time.
So maybe you’re the lucky one :-D
Cheers
The Lemmy.today instance owner got federation working again on 0.19.1 by doing a database query:
That fix is for another issue. I’ve had to do it once already, other admins - twice. It’s a bug since at least 0.18.4
Yeah this smells like the Friday evening bad push, but on a yearly scale 😁.
It’s been one week since you looked at me Cocked your head to the side and said, “I’m angry”
There’s a lesson to be learned here: don’t push a massive update close to the holidays because, ya know, you might break federation and go on vacation for a week.
I mean, no one has forced any admins to deploy a new version. But yeah, this is an annoying one.
Devs break federation.
You: here’s why it’s everyone else’s fault
Why would users do this?
It’s valid to point out when amateurs do amateur stuff, in the hopes they one day become experts.
Backup before upgrade. If you can’t, don’t be the first to upgrade. Have a test instance.
And if all of that sounds like too much, then just accept downtime as a lifestyle.
It’s valid to point out when amateurs do amateur stuff, in the hopes they one day become experts.
I agree, it’s valid to point out amateurish behavior, like devs releasing a highly anticipated major update that breaks core functionality… Then pushing an emergency “fix” that didn’t actually fix the problem and going radio silent for over a week because it’s the holidays. But sure, we can focus on server admins if you want.
It usually takes multiple mistakes for a failure this big.
It’s not a devs vs admins, this was a failure on both sides. This is early days for the Fediverse, I’d imagine this will shake out over time as unreliable instances are abandoned and we get more devs and they learn to or get what the resources needed for better testing.
It was supposed to be a new year gift for all of us.
There’s a lesson to be learned here
The lesson is don’t trust a fucking tankie to be able to run a development project
Wow a useless ad-hominem “argument”…
Nobody with actual cognitive capacity ends up as a tankie, and the main dev quite literally is a self-proclaimed tankie and pro-Stalinist
And yet you’re still here
Okay, you fix the software, then.
That’s ridiculous and you are letting your brain get clouded by your political views.
I don’t think any political stance can guarantee that one would (not) make a fuck up at any given time. The shit they do is lit, it lets me consume that post and then answer you, us being from different volunteer-run instances. Give these guys some credit. At least, they put their code where their mouth is and let us all use it.
In the language of 1900’s socialists, I can’t care whose gold in a cart that is, if I can appropriate it to serve our means.
If that’s not the case, we all can fork it. But I doubt you or I have enough spite to compete with them and continuously support it. With all problems, if they haven’t started their project, we couldn’t have these nice places, so even though I disagree with them, I can’t really devalue the labor they put in there, for everyone’s pleasure.
In my experience the worst thing about tankies is all the loud anti-tankie noise they attract like this comment.
I’m not one myself, but venom like this very much outweighs anything I’ve found untoward from any tankie here.
It’s like all the vegans vs the people that bitch about vegans.
Youre on that tankies platform right now, bro.
You love tankies or something? Using tankie-ware like you are?
If you don’t like their way of developing, then do it yourself, cunt.
Remember this comment the next time you say you dislike a movie, book, game or food. If you don’t like it, do it yourself cunt, criticism is not allowed unless you do it yourself
If I dislike a movie, book, game or food; I would criticise the movie, book, game or food and not the director’s, writer’s, developer’s or chef’s political views.
Don’t get me wrong, I’m not saying don’t criticise their political views. I’m saying don’t criticise the product because of their political views.
But we should trust an incel?
Curious.
Why are you even bothering to post here, fucking hypocrite. Go cry on your nazi substack.
Right, anybody who doesn’t like literal Stalinists must be a Nazi
Well then, take your beloved capitalism and get the hell out of here. There are lots of profit driven social media platforms that you could try out.
